PMM-12762 Get notified about new version. #2951
Conversation
Co-authored-by: Alex Demidoff <[email protected]>
Co-authored-by: Alex Demidoff <[email protected]>
Co-authored-by: Alex Demidoff <[email protected]>
Co-authored-by: Alex Demidoff <[email protected]>
BupycHuk
requested review from
idoqo and
JiriCtvrtka
and removed request for
a team
…ified-about-new-version # Conflicts: # managed/services/server/updater.go
| @@ -100,3 +101,14 @@ func (p *Parsed) Less(right *Parsed) bool { | |||
|
|
|||
| return p.Rest < right.Rest | |||
| } | |||
|
|
|||
| func (p *Parsed) UnmarshalJSON(b []byte) error { | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
exported: exported method Parsed.UnmarshalJSON should have comment or be unexported (revive)
managed/services/server/updater.go
Outdated
| parsed, err := version.Parse(splitTag[1]) | ||
| if err != nil { | ||
| up.l.Debugf("Failed to parse version: %s", splitTag[1]) | ||
| return &version.DockerVersionInfo{ |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
error is not nil (line 265) but it returns nil (nilerr)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #2951 +/- ##
==========================================
+ Coverage 44.44% 44.60% +0.16%
==========================================
Files 368 368
Lines 35582 35399 -183
==========================================
- Hits 15813 15791 -22
+ Misses 18142 17981 -161
Partials 1627 1627
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| while IFS= read -r service; do | ||
| echo "Logs for $service:" | ||
| docker exec pmm-server supervisorctl tail $service | ||
| done <<< "$services" |
There was a problem hiding this comment.
Are we going to keep these going forward?
There was a problem hiding this comment.
Yes, it's to debug in case of any upcoming issue
There was a problem hiding this comment.
I see. I find the following construct a bit simpler to understand:
for service in $services; do
echo "Logs for $service:"
docker exec pmm-server supervisorctl tail $service
done
Up to you :)
There was a problem hiding this comment.
That would be easier, but for the some reason it stores all lines as one element in services array. I tried that
There was a problem hiding this comment.
for service in "${services[@]}"; do - that is the syntax for looping through array elements.
# Conflicts: # api/serverpb/server.pb.go # descriptor.bin # docker-compose.yml # managed/services/server/server.go # managed/services/server/updater.go
Co-authored-by: Alex Demidoff <[email protected]>
PMM-12762
Link to the Feature Build: SUBMODULES-3612
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: