Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12899 Use module and build cache #2916

Draft
wants to merge 34 commits into
base: v3
Choose a base branch
from

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Mar 21, 2024

PMM-12899

Link to the Feature Build: SUBMODULES-3595

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.55%. Comparing base (a432058) to head (ccf3bf0).

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2916      +/-   ##
==========================================
- Coverage   44.58%   44.55%   -0.04%     
==========================================
  Files         367      367              
  Lines       35592    35592              
==========================================
- Hits        15870    15858      -12     
- Misses      18088    18100      +12     
  Partials     1634     1634              
Flag Coverage Δ
admin 11.65% <ø> (ø)
agent 52.61% <ø> (-0.14%) ⬇️
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SLACK_USERNAME: "PR pipelines bot"
SLACK_ICON_EMOJI: ":chestnut:"
SLACK_USERNAME: "Build bot"
SLACK_ICON_EMOJI: ":octocat:"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I couldn't resist - :octocat: seems to be much more to the point here :)

@ademidoff ademidoff force-pushed the PMM-12899-use-module-and-build-cache branch from 0069c2d to 853be6e Compare March 21, 2024 04:12
* PMM-12641 Fix the dashboard upgrade

This fixes a bug where, due to a wrong ansible formula, PMM would upgrade the dashboards no matter what :)

* PMM-12641 follow up on review
@ademidoff ademidoff force-pushed the PMM-12899-use-module-and-build-cache branch from 8a0c440 to 42a02a9 Compare April 1, 2024 00:20
@ademidoff ademidoff force-pushed the PMM-12899-use-module-and-build-cache branch from d613558 to bf640ca Compare April 3, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant