Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12895 Add metrics resolutions configuration to agents #2882

Merged
merged 15 commits into from
May 27, 2024

Conversation

artemgavrilov
Copy link
Contributor

@artemgavrilov artemgavrilov commented Mar 7, 2024

PMM-12895

Link to the Feature Build: SUBMODULES-3578

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.29%. Comparing base (09f3823) to head (0261fd9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2882      +/-   ##
==========================================
- Coverage   43.34%   43.29%   -0.06%     
==========================================
  Files         399      399              
  Lines       41516    41429      -87     
==========================================
- Hits        17996    17937      -59     
+ Misses      21514    21488      -26     
+ Partials     2006     2004       -2     
Flag Coverage Δ
admin 11.61% <ø> (-0.06%) ⬇️
agent 52.83% <ø> (ø)
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artemgavrilov artemgavrilov marked this pull request as ready for review March 7, 2024 18:43
@artemgavrilov artemgavrilov requested review from BupycHuk and a team as code owners March 7, 2024 18:43
@artemgavrilov artemgavrilov requested review from idoqo and JiriCtvrtka and removed request for a team March 7, 2024 18:43
Copy link
Member

@BupycHuk BupycHuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was the reason to update descriptor.bin? Does that mean that we introduced some backward-incompatible change?

api-tests/inventory/agents_azure_database_exporter_test.go Outdated Show resolved Hide resolved
api-tests/management/external_test.go Outdated Show resolved Hide resolved
descriptor.bin Outdated Show resolved Hide resolved
Copy link
Member

@BupycHuk BupycHuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we add a new test to scrape_configs_test with custom metrics resolution?

@artemgavrilov
Copy link
Contributor Author

LGTM, can we add a new test to scrape_configs_test with custom metrics resolution?

Functions from scrape_configs.go accept metrics resolutions as a parameter, so it doesn't matter from where it comes.

@artemgavrilov artemgavrilov merged commit 4bf51d1 into main May 27, 2024
31 checks passed
@artemgavrilov artemgavrilov deleted the PMM-12895-exporter-specific-metrics-resolutions branch May 27, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants