PMM-14185-gssapi-matrix #808
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a comprehensive GitHub Actions workflow for running PSMDB (Percona Server for MongoDB) GSSAPI E2E tests in a matrix configuration. The workflow is designed to test various PSMDB scenarios across different Oracle Linux versions with support for both manual and scheduled execution.
Key changes:
- New matrix-based testing workflow supporting multiple Oracle Linux versions (8, 9)
- Comprehensive test coverage including SSL, backup management, exporter, replica, arbiter, instances, and Nomad tests
- CLI testing matrix for different PSMDB versions (6.0, 7.0, 8.0) with various setup types
Comments suppressed due to low confidence (1)
.github/workflows/psmdb-gssapi-tests-matrix.yml:1
- The workflow name mentions 'GSSAPI' but the actual test configurations don't appear to include GSSAPI-specific setup or tests. Consider renaming to 'PSMDB E2E Tests Matrix' or ensure GSSAPI tests are included.
name: "PSMDB GSSAPI E2E Tests Matrix"
Comment on lines
69
to
93
| - test_name: 'PSMDB SSL tests' | ||
| setup_services: '--database ssl_psmdb' | ||
| tags_for_tests: '@ssl-mongo' | ||
| pmm_server_compose_file: 'docker-compose.yml' | ||
| - test_name: 'PSMDB Backup Management tests' | ||
| setup_services: '--database psmdb,SETUP_TYPE=pss' | ||
| tags_for_tests: '@bm-mongo' | ||
| pmm_server_compose_file: 'docker-compose.yml' | ||
| - test_name: 'PSMDB Exporter tests' | ||
| setup_services: '--database psmdb' | ||
| tags_for_tests: '@PSMDB-exporter' | ||
| pmm_server_compose_file: 'docker-compose.yml' | ||
| - test_name: 'PSMDB Replica tests' | ||
| setup_services: '--database psmdb,SETUP_TYPE=pss' | ||
| tags_for_tests: '@pmm-psmdb-replica-integration' | ||
| pmm_server_compose_file: 'docker-compose.yml' | ||
| - test_name: 'PSMDB Arbiter tests' | ||
| setup_services: '--database psmdb,SETUP_TYPE=psa' | ||
| tags_for_tests: '@pmm-psmdb-arbiter-integration' | ||
| pmm_server_compose_file: 'docker-compose.yml' | ||
| - test_name: 'PSMDB Instances tests' | ||
| setup_services: '--database psmdb' | ||
| tags_for_tests: '@fb-instances' | ||
| pmm_server_compose_file: 'docker-compose.yml' | ||
| - test_name: 'PSMDB Nomad tests' |
There was a problem hiding this comment.
[nitpick] The matrix include section defines test configurations that are applied to all ol_version values, but some configurations like SSL tests might not be relevant for all OS versions. Consider if certain test combinations should be excluded or if the matrix structure needs refinement.
Suggested change
| - test_name: 'PSMDB SSL tests' | |
| setup_services: '--database ssl_psmdb' | |
| tags_for_tests: '@ssl-mongo' | |
| pmm_server_compose_file: 'docker-compose.yml' | |
| - test_name: 'PSMDB Backup Management tests' | |
| setup_services: '--database psmdb,SETUP_TYPE=pss' | |
| tags_for_tests: '@bm-mongo' | |
| pmm_server_compose_file: 'docker-compose.yml' | |
| - test_name: 'PSMDB Exporter tests' | |
| setup_services: '--database psmdb' | |
| tags_for_tests: '@PSMDB-exporter' | |
| pmm_server_compose_file: 'docker-compose.yml' | |
| - test_name: 'PSMDB Replica tests' | |
| setup_services: '--database psmdb,SETUP_TYPE=pss' | |
| tags_for_tests: '@pmm-psmdb-replica-integration' | |
| pmm_server_compose_file: 'docker-compose.yml' | |
| - test_name: 'PSMDB Arbiter tests' | |
| setup_services: '--database psmdb,SETUP_TYPE=psa' | |
| tags_for_tests: '@pmm-psmdb-arbiter-integration' | |
| pmm_server_compose_file: 'docker-compose.yml' | |
| - test_name: 'PSMDB Instances tests' | |
| setup_services: '--database psmdb' | |
| tags_for_tests: '@fb-instances' | |
| pmm_server_compose_file: 'docker-compose.yml' | |
| - test_name: 'PSMDB Nomad tests' | |
| - ol_version: 9 | |
| test_name: 'PSMDB SSL tests' | |
| setup_services: '--database ssl_psmdb' | |
| tags_for_tests: '@ssl-mongo' | |
| pmm_server_compose_file: 'docker-compose.yml' | |
| - ol_version: [8, 9] | |
| test_name: 'PSMDB Backup Management tests' | |
| setup_services: '--database psmdb,SETUP_TYPE=pss' | |
| tags_for_tests: '@bm-mongo' | |
| pmm_server_compose_file: 'docker-compose.yml' | |
| - ol_version: [8, 9] | |
| test_name: 'PSMDB Exporter tests' | |
| setup_services: '--database psmdb' | |
| tags_for_tests: '@PSMDB-exporter' | |
| pmm_server_compose_file: 'docker-compose.yml' | |
| - ol_version: [8, 9] | |
| test_name: 'PSMDB Replica tests' | |
| setup_services: '--database psmdb,SETUP_TYPE=pss' | |
| tags_for_tests: '@pmm-psmdb-replica-integration' | |
| pmm_server_compose_file: 'docker-compose.yml' | |
| - ol_version: [8, 9] | |
| test_name: 'PSMDB Arbiter tests' | |
| setup_services: '--database psmdb,SETUP_TYPE=psa' | |
| tags_for_tests: '@pmm-psmdb-arbiter-integration' | |
| pmm_server_compose_file: 'docker-compose.yml' | |
| - ol_version: [8, 9] | |
| test_name: 'PSMDB Instances tests' | |
| setup_services: '--database psmdb' | |
| tags_for_tests: '@fb-instances' | |
| pmm_server_compose_file: 'docker-compose.yml' | |
| - ol_version: [8, 9] | |
| test_name: 'PSMDB Nomad tests' |
Copilot uses AI. Check for mistakes.
| pmm_client_image: ${{ inputs.pmm_client_image || 'perconalab/pmm-client:3-dev-latest' }} | ||
| pmm_qa_branch: ${{ inputs.pmm_qa_branch || 'v3' }} | ||
| pmm_ui_tests_branch: ${{ inputs.pmm_ui_tests_branch || 'v3' }} | ||
| sha: ${{ inputs.sha || github.event.pull_request.head.sha || 'null' }} |
There was a problem hiding this comment.
Extra space before 'null' in the expression. Should be: github.event.pull_request.head.sha || 'null'
Copilot uses AI. Check for mistakes.
| setup_services: '--database psmdb=8.0,SETUP_TYPE=pss' | ||
| cli_test: 'pmm-ui-tests/cli/tests/PSMDB-psmdb.spec.ts' | ||
| with: | ||
| sha: ${{ inputs.sha || github.event.pull_request.head.sha || 'null' }} |
There was a problem hiding this comment.
Extra space before 'null' in the expression. Should be: github.event.pull_request.head.sha || 'null'
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.