Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remaining python2.x print changed to py3 syntax #1374

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lightistor
Copy link

remaining print lines that used python 2.x type of syntax has been modified as they were causing issues when running with python3

@it-percona-cla
Copy link

it-percona-cla commented Aug 10, 2022

CLA assistant check
All committers have signed the CLA.

remaining print lines that used python 2.x type of syntax has been modified as they were causing issues when running with python3
@lightistor
Copy link
Author

@anton-bystrov can you please review and merge as the current version without this trivial fix is causing issues with any modern developer environment and can't be run with python2 due to py3 print() without the compatibility library imports

@odoucet
Copy link

odoucet commented May 17, 2024

hello,
this is an easy pull request; @lightistor please update your branch, and Percona, please merge this :)
Thanks for the work.

@lightistor
Copy link
Author

@odoucet i've updated it. here's to hoping @anton-bystrov reviews it.

@odoucet
Copy link

odoucet commented May 17, 2024

you may also update hashbang on top of file :)

Copy link
Contributor

@anton-bystrov anton-bystrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lightistor
Copy link
Author

@ademidoff can you approve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants