backport(v0.80.x): app: create event for when app parameters change #5108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
|
CI is failing here, due to very old CI trying to install unpinned deps. I'll work on a minimal change to add here so we can get CI green again. As for substantive review of the backport, first I need to handle penumbra-zone/reindexer#32, which will unblock functional testing of the new indexing logic. |
It's unfortunate that we can't put this somewhere else to avoid including cnidarium, and thus rocksdb, when you just want to read the event. A refactoring of the app crate to allow consuming it "as a component" can be added later.
conorsch
force-pushed
the
event-param-change-v0.80.x
branch
from
95c5c60 to
1dfbda9
Compare
conorsch
changed the title
cherry picked from commit 5717176, then bumped 1.80 -> 1.83. Also includes a `nix flake update` so that rust 1.83 is available. Doing this on a backport branch, so that CI passes against the `v0.80.x` code. This is necessary because the docs-lint dependencies aren't pinned, but should be. A few other fix-it commits were squashed into this one: lint: allow dead code in test modules lint: cargo fmt chore: bump proptest derive Required for getting `cargo check` to pass, errors were error: non-local `impl` definition, `impl` blocks should be written at the same level as their item --> crates/crypto/tct/src/epoch.rs:79:53 | 79 | #[cfg_attr(any(test, feature = "arbitrary"), derive(proptest_derive::Arbitrary))] | ^------------------------- | | | `Arbitrary` is not local | move the `impl` block outside of this constant `_IMPL_ARBITRARY_FOR_Root` 80 | pub struct Root(pub Hash); | ---- `Root` is not local
conorsch
force-pushed
the
event-param-change-v0.80.x
branch
from
2eb9a24 to
4f81e91
Compare
conorsch
added a commit
to penumbra-zone/reindexer
that referenced
this pull request
Mar 6, 2025
Updating the pinned commits for the git deps, based on recent changes to the CI in the corresponding protocol repo PRs [0, 1]. No functional changes to the logic. [0] penumbra-zone/penumbra#5109 [1] penumbra-zone/penumbra#5108
conorsch
added a commit
to penumbra-zone/reindexer
that referenced
this pull request
Mar 6, 2025
Updating the pinned commits for the git deps, based on recent changes to the CI in the corresponding protocol repo PRs [0, 1]. No functional changes to the logic. [0] penumbra-zone/penumbra#5109 [1] penumbra-zone/penumbra#5108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds an event which fires whenever the app parameters change, to easily allow indexing components to track the current parameters as needed.
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: