Mark emails as unreachable #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @henriqueberlesi, thanks you for taking on this issue! I’ll take a closer look in the coming days 😊 |
wmnnd
reviewed
Mar 28, 2025
lib/keila/mailings/worker.ex
Outdated
| @@ -106,19 +107,70 @@ defmodule Keila.Mailings.Worker do | |||
| # Email was already sent | |||
| defp handle_result({:error, :already_sent}, _), do: {:cancel, :already_sent} | |||
|
|
|||
| # Email is invalid | |||
| defp handle_result({:error, :invalid_email}, recipient) do | |||
| Multi.new() | |||
There was a problem hiding this comment.
Could you refactor this to just
Repo.transaction(fn ->
recipient
|> set_recipient_failed_query()
|> Repo.update_all([])
# ...
end)We don’t really use Ecto.Multi anywhere else in the codebase and so I think overall this is easier to read 😊
|
Sorry it took so long, but overall this PR is looking good and is a valuable contribution, thank you! I just left one small comment – and once that’s been addressed, I’d be happy to merge 🚀 |
|
@wmnnd thanks for the feedback! I refactored |
|
Excellent, thank you! Sorry for the nit-pick about Ecto.Multi 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt on #390.
Updating the
handle_resultfromKeila.Mailings.Workerto deal with the already existent:invalid_emailreturn error. The action will update thefailed_atdate for the recipient, and update the recipient's contact to theunreachableatom.Also, refactored a few queries into their own private functions. Maybe in the future these functions could be moved to their own service/module?
Also, @wmnnd: I have not found any tests covering this file. Should we add tests with this PR?
Thanks!