Move frontend tests to common #4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirunatan
force-pushed
the
hiru-move-front-tests
branch
8 times, most recently
from
ae2d31c
to
88d2772
Compare
hirunatan
force-pushed
the
hiru-move-front-tests
branch
2 times, most recently
from
ee5b3d3
to
57c4d37
Compare
hirunatan
force-pushed
the
hiru-move-front-tests
branch
from
57c4d37
to
77d4901
Compare
pabloalba
reviewed
Apr 30, 2024
| ;; will not have any effect, and so the parent shape won't also be touched. | ||
| changes (cflh/generate-relocate-shapes (pcb/empty-changes) | ||
| (:objects page) | ||
| #{(thi/id :copy-root)} ; parents |
There was a problem hiding this comment.
This should be the parent of the shape that you are moving: #{(:parent-id (thf/get-shape :free-shape))} Or in this case uuid/zero
pabloalba
reviewed
Apr 30, 2024
| ;; will not have any effect, and so the parent shape won't also be touched. | ||
| changes (cflh/generate-relocate-shapes (pcb/empty-changes) | ||
| (:objects page) | ||
| #{(thi/id :copy-root)} ; parents |
There was a problem hiding this comment.
This should be the parent of the shape that you are moving: #{(:parent-id copy-child1)}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.