Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve django action devex #13

Merged
merged 4 commits into from
Oct 1, 2023
Merged

Improve django action devex #13

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb570d8
Update action.yaml
AaDalal Sep 18, 2023
8af8ecf
Add black --diff
AaDalal Sep 19, 2023
ed0dab4
Use python version container
AaDalal Sep 19, 2023
3de986f
Make lint continue on error
AaDalal Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions django-check/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ runs:
cd ${{ inputs.path }}
pip install pipenv
pipenv install --deploy --dev
- name: Test (run in parallel)
shell: bash
run: |-
cd ${{ inputs.path }}
pipenv run coverage run --concurrency=multiprocessing manage.py test --settings=${{ inputs.projectName }}.settings.ci --parallel
joyliu-q marked this conversation as resolved.
Show resolved Hide resolved
pipenv run coverage combine
- name: Lint (flake8)
shell: bash
run: |-
Expand All @@ -50,13 +56,7 @@ runs:
shell: bash
run: |-
cd ${{ inputs.path }}
pipenv run black --check .
pipenv run black --check . || pipenv run black --diff .
AaDalal marked this conversation as resolved.
Show resolved Hide resolved
if: ${{ inputs.black }}
- name: Test (run in parallel)
shell: bash
run: |-
cd ${{ inputs.path }}
pipenv run coverage run --concurrency=multiprocessing manage.py test --settings=${{ inputs.projectName }}.settings.ci --parallel
pipenv run coverage combine
# container:
# image: python:${{ inputs.pythonVersion }}
container:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we want to bring this back?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do all products use the same python version? If I remember correctly, that's not true, which is the rationale for bringing this back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why we removed it, though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add it back temporarily and monitor closely.

image: python:${{ inputs.pythonVersion }}