Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Coverage Fix #164

Closed
wants to merge 18 commits into from
Closed

Code Coverage Fix #164

wants to merge 18 commits into from

Conversation

judtinzhang
Copy link
Member

@judtinzhang judtinzhang commented Oct 14, 2023

In addition to code coverage fixes, the following also needed to be updated to pass checks

  • Migrating max length for major and minor name to 150 to accommodate for new majors added in 2023
  • Upgrading black because of bad version
  • Install backports.zoneinfo because of known issue (since platform is on python version < 3.9)

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (daf9ff9) 97.87% compared to head (2402252) 96.99%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   97.87%   96.99%   -0.88%     
==========================================
  Files          15       15              
  Lines         799      799              
==========================================
- Hits          782      775       -7     
- Misses         17       24       +7     
Flag Coverage Δ
backend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
backend/accounts/backends.py 100.00% <100.00%> (ø)
backend/accounts/models.py 100.00% <100.00%> (ø)

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@judtinzhang judtinzhang closed this Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant