PCA Resyncing Logic #668
PCA Resyncing Logic #668
Conversation
| @@ -806,9 +806,7 @@ def test_alert_called_wrong_sem(self, mock_alert): | |||
| "sent" in json.loads(res.content)["message"], | |||
| ) | |||
| self.assertFalse(mock_alert.called) | |||
| self.assertEqual(1, StatusUpdate.objects.count()) | |||
| u = StatusUpdate.objects.get() | |||
| self.assertFalse(u.alert_sent) | |||
There was a problem hiding this comment.
why does this test change?
There was a problem hiding this comment.
My understanding is this test was kind of flawed from the beginning – it attempts to create a StatusUpdate object with a poorly formatted semester. In the record_update function there is a check after the creation of the object that raises an error if the semester is poorly formatted. When changing it to transaction.atomic(), throwing this error leads to reverting the creation of StatusUpdate, which makes more sense logically anyways, as a StatusUpdate object with a poorly formatted semester doesn't make sense.
| section.save() | ||
|
|
||
| # Add corresponding status update object | ||
| if add_status_update and last_status_update.new_status != course_status: |
There was a problem hiding this comment.
This does resyncing manually, but this means we would have to run this on a corn all the time right? This definitely solves one problem, but we still probably need to do something to fix the underlying issue (why do they mismatch ever?)
There was a problem hiding this comment.
Yeah agreed, I think it's more of a temporary solution (similar to webhookbackup), that we can use while Penn figured out their problems.
transaction.atomic()wrapper to webhook database calls, to reduce potential consistency errors between our StatusUpdate models and our Section model. This required modifying one of our existing test cases.loadstatusmanagement command to conditionally add StatusUpdate objects to ensure consistency between the last StatusUpdate and the status attribute of the Section model.registrarimportalso usesloadstatus's logic, but it currently does not add StatusUpdate objects – this can be changed easily by settingadd_status_update=True.