Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDP Fixes #621

Merged
merged 8 commits into from
Apr 7, 2024
Merged

PDP Fixes #621

merged 8 commits into from
Apr 7, 2024

Conversation

AaDalal
Copy link
Contributor

@AaDalal AaDalal commented Apr 7, 2024

Frontend

  1. wrapping on search conditions
  2. filter by startingYear when searching for degrees

Backend

  1. update degree parser to handle course requirements where the department/disciplien is "@"
  2. fixed a bug with the way the person field of docked course was being populated

Requires reloading degrees

Clue88
Clue88 approved these changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@Clue88 Clue88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaDalal AaDalal merged commit d668040 into master Apr 7, 2024
13 checks passed
@AaDalal AaDalal deleted the aag/fixes branch April 7, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clue88 Clue88 Clue88 approved these changes

@ashleymyan ashleymyan Awaiting requested review from ashleymyan

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AaDalal @Clue88