-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pipenv with poetry #567
Open
Clue88
wants to merge
12
commits into
master
Choose a base branch
from
poetry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,611
−2,603
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
511a506
Replace pipenv with poetry
Clue88 4e02d70
hopefully CI is fixed and not horrible
Clue88 8c2dad2
surely this will work
Clue88 1dc27b5
Move poetry into backend
Clue88 6925014
yet another ci pipeline :/
Clue88 a0b331e
Add shortener and cors packages
Clue88 56ff4ab
Add more missing dependencies (do we need all of these?)
Clue88 05b648e
Lock python version to 3.10.x
Clue88 41b1a97
Replace pipenv with poetry in docs
Clue88 66bd2c0
Update dockerfile to use poetry
Clue88 19d1ece
Fix poetry installation in django-base
Clue88 b5582c7
Install poetry deps to system for prod
Clue88 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,13 +9,14 @@ on: push | |
jobs: | ||
backend-check: | ||
name: "Backend Check" | ||
uses: pennlabs/shared-actions/.github/workflows/django.yaml@8785a7d7b9158d8d5705a0202f5695db2c0beb97 | ||
uses: pennlabs/shared-actions/.github/workflows/django.yaml@7b67c73ced6fa70043451f6816c706a003642828 | ||
with: | ||
projectName: PennCourses | ||
path: backend | ||
flake: true | ||
black: true | ||
pythonVersion: 3.10-buster | ||
dependencyManager: poetry | ||
|
||
publish-backend: | ||
uses: pennlabs/shared-actions/.github/workflows/[email protected] | ||
|
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,15 @@ | ||
FROM pennlabs/django-base:f0f05216db7c23c1dbb5b95c3bc9e8a2603bf2fd | ||
FROM pennlabs/django-base:281d2f6446bb5381e1a2ecf39f6689b648d92ee6-3.10.1 | ||
|
||
LABEL maintainer="Penn Labs" | ||
|
||
WORKDIR /backend | ||
|
||
# Copy project dependencies | ||
COPY Pipfile* ./ | ||
COPY pyproject.toml ./ | ||
COPY poetry.lock ./ | ||
|
||
# Install backend dependencies | ||
RUN pipenv install --dev | ||
RUN poetry install --no-root | ||
|
||
# Alias runserver command | ||
RUN echo 'alias runserver="python manage.py runserver 0.0.0.0:8000"' >> ~/.bashrc |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having to pin like this sucks because its pretty opaque :(