Ryder PCA Sorting #540
Open
Ryder PCA Sorting #540
+183
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyjiang3
requested changes
Nov 5, 2023
| rownum: number; | ||
| } | ||
| export const AlertHeader = ({ course, rownum }: AlertHeaderProps) => { | ||
| return ( |
| @@ -109,6 +195,25 @@ export const ManageAlert = ({ | |||
| ); | |||
| }; | |||
|
|
|||
| let rowNum = 0; | |||
There was a problem hiding this comment.
nit: lets move this to under useStates
|
|
||
| return res; | ||
| }, {}); | ||
|
|
There was a problem hiding this comment.
can we generalize this with the other grouping and put it in a shared util file?
| rowNum++; | ||
| return ( | ||
| <> | ||
| <AlertHeader course={key} rownum={rowNum} /> |
There was a problem hiding this comment.
++rowNum here, then we can remove rowNum++ above
| <AlertItem | ||
| key={alert.id} | ||
| checked={alertSel[alert.id]} | ||
| rownum={rowNum} |
There was a problem hiding this comment.
++rowNum here, then we can removerowNum++ above
nit: rowNum instead?
| @@ -90,6 +91,91 @@ export const ManageAlert = ({ | |||
| const [searchTimeout, setSearchTimeout] = useState<number>(); | |||
| const [numSelected, setNumSelected] = useState(0); | |||
|
|
|||
| // Alerts for testing | |||
| <> | ||
| <AlertHeader course={key} rownum={rowNum} /> | ||
| {groupedAlerts[key]?.map?.((alert) => { | ||
| console.log(alert); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote sorting logic for manage alerts page so alerts are now grouped by course in lexicographical order. Created banner for course groupings.