Move club cards display to masonry layout #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianweng
reviewed
Aug 24, 2024
frontend/components/ClubDisplay.tsx
Outdated
| <StyledMasonry | ||
| breakpointCols={{ | ||
| default: 2, | ||
| 960: 1, |
There was a problem hiding this comment.
Ideally use some existing constant to define sm screen sizes
julianweng
reviewed
Aug 24, 2024
| default: 2, | ||
| 960: 1, | ||
| }} | ||
| className="masonry-grid" |
There was a problem hiding this comment.
Is the classname for the parent Masonry component ever used?
julianweng
requested changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The front page currently displays club cards in two columns, with each "row" of cards beginning at the same point. This creates gaps when one column contains cards with longer lengths than the other. This PR moves to a masonry layout.
Here's a before vs after comparison. Before:
After: