umpf: answer interactive prompts with default when --default set #50
Conversation
|
I think a |
|
Ok, but doesn't it make sense to have piping yes behave as expected as well? |
|
Fair point. I would rename the option then though. How about |
|
Sounds good. |
a3f
changed the title
| else | ||
| read -e -i "$def" -p "$prompt: " choice | ||
| fi | ||
| } |
There was a problem hiding this comment.
Please use ${...} for all variables. We're not fully consistent overall, but it used in most cases.
And choice schould be a local variable.
Same everywhere else.
There was a problem hiding this comment.
choice is intentionally not local, so it can be used outside the function. I am not good enough at bash to make it work with a local, can you elaborate?
There was a problem hiding this comment.
Ah, sorry, I put that comment in the wrong place. It should be local in the calling function.
There was a problem hiding this comment.
My understanding was that choice as written by read_interactive is a global variable, so the callers need to access to choice global variable. I need to try out whether it still works with local in the calling function
There was a problem hiding this comment.
A local variable in bash is valid until the end of the function, including all functions that are called within that function.
When building or tagging an umpf, umpf can ask which branch to use when multiple are available. Piping yes(1) into umpf in this case doesn't work, because the variable populated by read in that case is left empty. Provide for this use case, a --default option that will take a default if one is known. Signed-off-by: Ahmad Fatoum <[email protected]>
When building or tagging an umpf, umpf can ask which branch to use when multiple are available. Piping
yes(1)into umpf in this case doesn't work, because the variable populated by read in that case is left empty.Handle this case to reduce user confusion.