Switch to Qt6 and rename GstPlayer -> GstGLPlayer #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the necessary changes for the Plugin to support Qt6 instead of Qt5. Signed-off-by: Sven Püschel <[email protected]>
Rename the element to include the fact that this element uses OpenGL as accelleration. This matches the naming of the underlying GStreamer QML element. Signed-off-by: Sven Püschel <[email protected]>
Use QThreadPool::start instead of QtConcurrent::run based on the suggestion
from a compiler warning when compiling with Qt 6.7.2:
warning: ignoring return value of ‘auto QtConcurrent::run(Function&&, Args&& ...) [with Function = GstStateChangeReturn (&)(_GstElement*, GstState); Args = {_GstElement*&, GstState}’, declared with attribute ‘nodiscard’: ‘Use QThreadPool::start(Callable&&) if you don't need the returned QFuture’
Signed-off-by: Sven Püschel <[email protected]>
tretter
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.