Build #14
Merged
Build #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first step towards making a real library with a stable API sometimes in the end. Due to internal dependencies there a two libraries at the moment: libmosqagent and libmosqhelper. Set the global CMake variable BUILD_SHARED_LIBS to control if shared or static libs are generated (you can use the new introduced option for that). The first agent mqtt-clock just links the two internal libraries then. Version numbering follows the semantic versioning approach, see https://apr.apache.org/versioning.html or https://semver.org/ for details. Note: nothing is installed so far.
This will install both libraries, headers, exported cmake targets, and the one agent binary to standard GNU installation directories.
We include stdbool.h all over the project. This header comes with C99, so we must require it.
* Move header files, library implementation, and example agents all to separate directories * Move CMake code to separate CMakeLists.txt files in the new subfolders * Rename mosqagent.[ch] files to mqtta.[ch]
penguineer
approved these changes
Dec 1, 2017
penguineer
approved these changes
Dec 1, 2017
penguineer
approved these changes
Dec 1, 2017
penguineer
approved these changes
Dec 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major build improvements, no code changes (despite of adapted includes), just renames, moves, and CMake stuff. Not complete, but enough to proceed with the code parts.
Note: Whitespace may not be consistent, may be solve that with #11?