Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement resp DEL command #67

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

hderms
Copy link
Contributor

@hderms hderms commented Feb 9, 2023

Adds:

  • the RESP command parsing for DEL

Notes:

  • we will potentially need to rethink the relationship between a protocol and the underlying storage if we end up having Redis use both segcache and other datastructures, as del is supposed to work on a set of keys of any data type. One protocol would then need to be able to juggle multiple storage layers and know which keys belong in which storage layer, so it can delete the entry from the correct one (or just delete it from all of them, but we'd still need to deal with this fact if we implement COPY)
  • del doesn't dedupe or verify uniqueness of keys. Not sure what Redis does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant