Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
checked_mul
andchecked_add
available to Rust. It's slightly slower than the stdlibstring::parse<i64>()
at this point, but works from a&[u8]
and respects Redis parsing rules, so is preferable for this use caseINCR
SET
RESP command now eagerly checks whether the input value can be parsed as an i64, and if so, stores it as one. Otherwise it stores bytes (current behavior)Notes:
checked_add
with the SegcacheValue
and determining whether it would overflow if we viewed the underlying u64 as an i64 and added to it. If it would not overflow, we simply update the underlying u64 usingwrapping_add
which would be guaranteed not to overflow provided nothing happens in between the check and set, which should be true currently. Adding i64 support to Segcache is probably desirable, but if storage is currently single-threaded, then the current implementation should work