Skip to content

feat: barging with thread local queue nodes #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

pedromfedricci
Copy link
Owner

@pedromfedricci pedromfedricci commented Feb 5, 2025

For mcslock::barging::Mutex:

If the thread_local feature is enabled (not no_std compatible), locking operations that block (lock and lock_then) will access and modify queue nodes stored at the thread local storage of the locking threads. Else, these locking operations will allocate a queue node in the stack, for each call (no_std compatible). The later is current behavior.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 93.75000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.61%. Comparing base (c0ebb14) to head (25a3b81).

Files with missing lines Patch % Lines
src/inner/raw/mod.rs 87.50% 2 Missing ⚠️
src/inner/barging/thread_local.rs 85.71% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   98.90%   98.61%   -0.30%     
==========================================
  Files           9       11       +2     
  Lines         275      288      +13     
==========================================
+ Hits          272      284      +12     
- Misses          3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedromfedricci pedromfedricci changed the title feat:barging with thread local queue nodes feat: barging with thread local queue nodes Feb 5, 2025
@pedromfedricci pedromfedricci marked this pull request as ready for review February 5, 2025 02:39
@pedromfedricci pedromfedricci merged commit 397fa30 into main Feb 5, 2025
10 checks passed
@pedromfedricci pedromfedricci deleted the barging-with-thread-local-queue-nodes branch February 5, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants