Update README.md #50

VAllens · 2017-09-20T07:51:13Z

Fixed start.sh bug.

pecigonzalo · 2017-09-20T08:25:32Z

Fixes: #49
Relates to: #43

VAllens · 2017-09-20T08:36:16Z

Ok, this is good.
Thanks

VAllens · 2017-09-21T12:15:59Z

Can you merge this PR? Thank you

pecigonzalo · 2017-09-21T17:24:55Z

Ill merge it once I had time to test it. You can freely change your script, as its not part of the Go compiled code.

VAllens · 2017-09-22T03:42:36Z

I see. Thank you. :) 👍

pecigonzalo

If we sort the comments im ready to merge this.
Im a bit confused now tho, is /mnt/c the path for WSL and /c for Git Bash or the other way around?

pecigonzalo · 2017-11-22T17:49:20Z

README.md

@@ -54,7 +55,7 @@ add it to your $PATH.
 ```none
 #!/bin/bash

-  export PATH="$PATH:/mnt/c/Program Files (x86)/VMware/VMware Workstation"
+    export PATH="$PATH:/mnt/c/Program Files (x86)/VMware/VMware Workstation"


This seems to be causing a break in the codeblock. Could you verify?

pecigonzalo · 2017-11-22T17:50:53Z

README.md

+ Enter & Run `C:\Program Files\Docker Toolbox\start.sh` in `bash` window.
+
+2. Change `export PATH="$PATH:/mnt/c/Program Files (x86)/VMware/VMware Workstation"` to `export PATH="$PATH:/c/Program Files (x86)/VMware/VMware Workstation"` in `start.sh`.
+   Find `Docker Quickstart Terminal` on the desktop and double-click to run(need installed `Git Bash`).


(requires Git Bash)

could be better there, wdyt?

The better reason for WSL is that it is more convenient and quicker.

No, i meant change the text to

(requires Git Bash)

instead of

need installed

pecigonzalo · 2017-11-22T17:53:23Z

README.md

@@ -141,6 +142,22 @@ add it to your $PATH.

 ## Usage

+Usage `WSL (Windows Subsystem for Linux)` can be perfect to run this scripts, otherwise you can only modify the script after using `Git Bash` to run.
+So you'd better install and use `WSL` to run scripts.


I think this section is not that clear, maybe we can rephrase?

WSL (Windows Subsystem for Linux)is a perfect option to run this script otherwise, you can modify the scripts as outlined below to run with otherbashtools likeGit BashorMSYS2`

We can write two script files for WSL (Windows Subsystem for Linux) and Git Bash, or try to write a script file that is compatible with both.
This is WSL:

This is Git Bash:

There are some differences between the two.
The differences I have known are: path problems.
In the WSL: /mnt/c/xxxxx.
In the Git Bash: /c/xxxxx.

Yeah, I know both, the main difference for this is just the mount path, that is all. It might be better to script the detection of the environment than to have 2 scripts.

pecigonzalo · 2017-11-22T17:54:00Z

README.md

+2. Change `export PATH="$PATH:/mnt/c/Program Files (x86)/VMware/VMware Workstation"` to `export PATH="$PATH:/c/Program Files (x86)/VMware/VMware Workstation"` in `start.sh`.
+   Find `Docker Quickstart Terminal` on the desktop and double-click to run(need installed `Git Bash`).
+
+3. Change `export PATH="$PATH:/mnt/c/Program Files (x86)/VMware/VMware Workstation"` to `export PATH="$PATH:/c/Program Files (x86)/VMware/VMware Workstation"` in `C:\Program Files\Docker Toolbox\start.sh`.


Both for 2. and 3. could we break the export [...] commands to multiple lines to make it more readable?

I dont really see the difference between 2. and 3. could you explain?

Usage WSL:
Run directly using your script file.

Usage Git Bash:
After modifying the script file, run Docker Quickstart Terminal on the desktop directly.
OR
After modifying the script file, run Git Bash directly and Enter C:\Program Files\Docker Toolbox\start.sh in the Git Bash window.

VAllens

Okey

VAllens · 2017-11-24T02:26:15Z

README.md

@@ -141,6 +142,22 @@ add it to your $PATH.

 ## Usage

+Usage `WSL (Windows Subsystem for Linux)` can be perfect to run this scripts, otherwise you can only modify the script after using `Git Bash` to run.
+So you'd better install and use `WSL` to run scripts.


We can write two script files for WSL (Windows Subsystem for Linux) and Git Bash, or try to write a script file that is compatible with both.
This is WSL:

This is Git Bash:

There are some differences between the two.
The differences I have known are: path problems.
In the WSL: /mnt/c/xxxxx.
In the Git Bash: /c/xxxxx.

VAllens · 2017-11-24T02:35:27Z

README.md

+ Enter & Run `C:\Program Files\Docker Toolbox\start.sh` in `bash` window.
+
+2. Change `export PATH="$PATH:/mnt/c/Program Files (x86)/VMware/VMware Workstation"` to `export PATH="$PATH:/c/Program Files (x86)/VMware/VMware Workstation"` in `start.sh`.
+   Find `Docker Quickstart Terminal` on the desktop and double-click to run(need installed `Git Bash`).


The better reason for WSL is that it is more convenient and quicker.

VAllens · 2017-11-24T02:36:46Z

README.md

+2. Change `export PATH="$PATH:/mnt/c/Program Files (x86)/VMware/VMware Workstation"` to `export PATH="$PATH:/c/Program Files (x86)/VMware/VMware Workstation"` in `start.sh`.
+   Find `Docker Quickstart Terminal` on the desktop and double-click to run(need installed `Git Bash`).
+
+3. Change `export PATH="$PATH:/mnt/c/Program Files (x86)/VMware/VMware Workstation"` to `export PATH="$PATH:/c/Program Files (x86)/VMware/VMware Workstation"` in `C:\Program Files\Docker Toolbox\start.sh`.


Usage WSL:
Run directly using your script file.

Usage Git Bash:
After modifying the script file, run Docker Quickstart Terminal on the desktop directly.
OR
After modifying the script file, run Git Bash directly and Enter C:\Program Files\Docker Toolbox\start.sh in the Git Bash window.

Karrq · 2019-07-18T08:57:04Z

If you add the WSL as requirement it locks out anybody not in Windows 10.

Update README.md

27c3c98

Fixed start.sh bug.

pecigonzalo mentioned this pull request Sep 20, 2017

Fix for start.sh #43

Closed

giovannicandido mentioned this pull request Nov 12, 2017

Failed to run with Vmware Workstation 14 #52

Closed

VAllens added 2 commits November 22, 2017 12:21

Update README.md

ace353e

Update README.md

7abef40

pecigonzalo requested changes Nov 22, 2017

View reviewed changes

VAllens commented Dec 12, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update README.md #50

Update README.md #50

VAllens commented Sep 20, 2017

pecigonzalo commented Sep 20, 2017 •

edited

Loading

VAllens commented Sep 20, 2017

VAllens commented Sep 21, 2017

pecigonzalo commented Sep 21, 2017

VAllens commented Sep 22, 2017

pecigonzalo left a comment

pecigonzalo Nov 22, 2017

pecigonzalo Nov 22, 2017

VAllens Nov 24, 2017

pecigonzalo Dec 12, 2017

pecigonzalo Nov 22, 2017

VAllens Nov 24, 2017

pecigonzalo Dec 12, 2017

pecigonzalo Nov 22, 2017

pecigonzalo Nov 22, 2017

VAllens Nov 24, 2017

VAllens left a comment

VAllens Nov 24, 2017

VAllens Nov 24, 2017

VAllens Nov 24, 2017

Karrq commented Jul 18, 2019 •

edited

Loading

Update README.md #50

Are you sure you want to change the base?

Update README.md #50

Conversation

VAllens commented Sep 20, 2017

pecigonzalo commented Sep 20, 2017 • edited Loading

VAllens commented Sep 20, 2017

VAllens commented Sep 21, 2017

pecigonzalo commented Sep 21, 2017

VAllens commented Sep 22, 2017

pecigonzalo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VAllens left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Karrq commented Jul 18, 2019 • edited Loading

pecigonzalo commented Sep 20, 2017 •

edited

Loading

Karrq commented Jul 18, 2019 •

edited

Loading