Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Output similar commands or script command when the input command is not correct #3274

Merged
merged 9 commits into from
Nov 12, 2024

Conversation

Zheaoli
Copy link
Contributor

@Zheaoli Zheaoli commented Nov 11, 2024

Signed-off-by: Manjusaka [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Support #3270

@Zheaoli
Copy link
Contributor Author

Zheaoli commented Nov 11, 2024

image

Copy link
Collaborator

@frostming frostming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, it is a good start point and we can investigate how to implement the same for subcommands.

src/pdm/cli/utils.py Outdated Show resolved Hide resolved
src/pdm/cli/utils.py Outdated Show resolved Hide resolved
src/pdm/cli/utils.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.31%. Comparing base (91e02dd) to head (29d5482).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pdm/core.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3274      +/-   ##
==========================================
+ Coverage   85.29%   85.31%   +0.02%     
==========================================
  Files         112      112              
  Lines       11375    11399      +24     
  Branches     2479     2487       +8     
==========================================
+ Hits         9702     9725      +23     
  Misses       1145     1145              
- Partials      528      529       +1     
Flag Coverage Δ
unittests 85.11% <96.42%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zheaoli
Copy link
Contributor Author

Zheaoli commented Nov 11, 2024

I have fixed the code base on the review idea.

Here's new screenshot

image

@frostming PTAL

Copy link
Collaborator

@frostming frostming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI looks great

Signed-off-by: Manjusaka <[email protected]>
@frostming frostming merged commit 8c1758f into pdm-project:main Nov 12, 2024
24 checks passed
@Zheaoli Zheaoli deleted the manjusaka/support-3270 branch November 13, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants