Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pdm 2.20.1 breaks when optional dependency groups contain underscores #3272

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

frostming
Copy link
Collaborator

Fixes #3271

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.28%. Comparing base (04f0b69) to head (277986d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3272      +/-   ##
==========================================
- Coverage   85.29%   85.28%   -0.01%     
==========================================
  Files         112      112              
  Lines       11375    11375              
  Branches     2478     2479       +1     
==========================================
- Hits         9702     9701       -1     
- Misses       1145     1146       +1     
  Partials      528      528              
Flag Coverage Δ
unittests 85.08% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit 91e02dd into main Nov 11, 2024
23 of 24 checks passed
@frostming frostming deleted the frostming/issue3271 branch November 11, 2024 09:13
Zheaoli pushed a commit to Zheaoli/pdm that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdm 2.20.1 breaks when optional dependency groups contain underscores
1 participant