Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add python3 and virtual environment support #8

Open
wants to merge 40 commits into
base: master
Choose a base branch
from

Conversation

mojibake-umd
Copy link
Contributor

@mojibake-umd mojibake-umd commented Nov 4, 2022

Provides support for python3 and installing yas3fs into virtual environment,
as to not conflict with system python which maybe managed by vendor pip packages.

I have tested on RHEL7 and RHEL8.
I worked on this and then let it sit for a while, but it has been running on
a dev RHEL7 machine for a while now. I think it is ready for some wider testing.

Please provide some feedback.
I will try not to push any breaking changes, but it does not hurt to point to a commit id,
if you do not want anything to break on your systems.

mojibake-umd and others added 30 commits July 8, 2022 12:09
augeaus module was removed from core Puppet
in version 6.

match puppet version requirement in
metadata.json by requiring augeas_core
service_provider fact supported in stdlib since
version 4.10.0
Newer python setuptools installs to /usr/local/bin ???
@pcfens
Copy link
Owner

pcfens commented Nov 7, 2022

This looks great - as you might have guessed based on the recent updates I don't use yas3fs anymore, but am happy to merge this and upload it to the forge. Based on your todo it looks like I should probably wait until after the rEADME is updated too. If there's anything I can help with just let em know and I'm happy to. Thanks again!

@mojibake-umd
Copy link
Contributor Author

@pcfens Thanks for the feedback. Busy with other tasks as work (Use this in production deployment, so this is work stuff). But I will see if I can update some Readme and documentation by the end of November, and maybe by that time others can provide some feedback. I tried to keep compatibility but some times need to move on. May need to bump major version 1.0.0 to reflect some breakage. I need to review myself what I wrote.

Ron Aughenbaugh added 5 commits November 11, 2022 14:25
As this change breaks current expected behavior
a major version bump is appropriate.

1.0.0 does not mean production ready.
Use at own risk.
@mojibake-umd
Copy link
Contributor Author

Updated documentation and README.md.
@pcfens I bumped version to 1.0.0. you can decide if you think that is appropriate or not.
Feel free to remove WIP and merge when you feel comfortable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants