Skip to content

i1027: corrected asynchronous debugging output messages. #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

clevengr
Copy link
Contributor

@clevengr clevengr commented May 3, 2025

Description of what the PR does

Cherry-picks commit 32f18fa from branch i1027 to merge corrections fixing the incorrect logging of asynchronous operations in app.component.ts.

Issue which the PR addresses

Fixes #1086

Environment in which the PR was developed (OS,IDE, Java version, etc.)

Windows 10, Eclipse 2021-12, Java "1.8.0_381"

Precise steps for testing the PR:

  • Start a contest (e.g. sumithello)
  • Start a WTI Server
  • Login as a team using the WTI client
  • Open the browser console window
  • Examine the console log messages
    • verify that the messages include logging calls to loadEnvironment() BUT they do not display any actual environment values at that point;
    • verify that there are subsequent messages indicating "Received callback from asynchronous HttpClient.get();" followed by actual environment values.
  • Hit F5; repeat the above verification steps.

@clevengr clevengr added bug Something isn't working WTI-UI This bug or feature request applies to the WTI-UI (browser-side). In PR code review One Approval A very low risk and low LOE PR/Change labels May 3, 2025
Copy link
Collaborator

@johnbrvc johnbrvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Local testing seems to indicate it prints what it should.

@johnbrvc johnbrvc added this to the 9.11.0 milestone May 3, 2025
Copy link
Collaborator

@kkarakas kkarakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me. Didn't run it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working In PR code review One Approval A very low risk and low LOE PR/Change WTI-UI This bug or feature request applies to the WTI-UI (browser-side).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asynchronous logging in WTI-UI is wrong
3 participants