Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): remove deprecated disableCard param #379

Merged
merged 1 commit into from Jun 2, 2023

Conversation

gregjopa
Copy link
Contributor

@gregjopa gregjopa commented Jun 2, 2023

The disableFunding param is the recommended way to prevent specific funding instruments from showing in the smart buttons stack. To disable the card, disableFunding: "card" should be used instead of the legacy disableCard option.

@gregjopa gregjopa requested a review from a team as a code owner June 2, 2023 19:36
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0fa0336) 100.00% compared to head (dcdc576) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #379   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          299       299           
  Branches        56        56           
=========================================
  Hits           299       299           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gregjopa gregjopa merged commit a4abfc2 into main Jun 2, 2023
4 checks passed
@gregjopa gregjopa deleted the remove-disable-card branch June 2, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants