Use camelCase instead of kebab-case for params (breaking change!) #375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a breaking interface change for the types for the
loadScript(PayPalScriptOptions)
loader function. It changes thePayPalScriptOptions
interface to use camelCase instead of kebab-case.I think this would improve the developer experience since JS devs are familiar to camelCase for all the things. Note that we would still pass query params and data attributes as kebab-case under the hood but would hide this from the public interface.
The TypeScript types have been updated to use camelCase format for
PayPalScriptOptions
and follow this Google JS Style Guide for naming conventions for acronyms.https://google.github.io/styleguide/jsguide.html#naming-camel-case-defined
Before
After