Skip to content

hasReturned uses app switch state #2489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

imbrian
Copy link
Contributor

@imbrian imbrian commented Apr 24, 2025

Description

hasReturned will return true in the presence of app switch params. If called after an app switch (non-resume) flow, this can call onApprove twice.

  • adds appSwitchState to Buttons component
  • sets state when hashchange and visibilitychange listeners are added in the app switch flow
  • if an app switch flow has started in the current button instance, hasReturned should not return true

Why are we making these changes? Include references to any related Jira tasks or GitHub Issues

Reproduction Steps (if applicable)

Screenshots (if applicable)

Dependent Changes (if applicable)

Groups who should review (if applicable)

❤️ Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant