DTPPCPSDK-2227: Return V2 Variables from getHostedButtonDetails 馃懢 #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsbrunson
approved these changes
May 1, 2024
imbrian
approved these changes
May 1, 2024
src/hosted-buttons/types.js
Outdated
| @@ -34,6 +34,11 @@ export type HostedButtonsInstance = {| | |||
| render: (string | HTMLElement) => Promise<void>, | |||
| |}; | |||
|
|
|||
| export type HostedButtonPreferences = {| | |||
| buttonPreferences: $ReadOnlyArray<string>, | |||
There was a problem hiding this comment.
Possible to narrow these string types to known preferences and sources? Could do that in follow-up implementation PR too
nbierdeman
approved these changes
May 2, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/ncp/api/form-fields/, I added some quick unit tests to make suregetHostedButtonDetailscan handle either response appropriately.Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
JIRA: DTPPCPSDK-2227
Reproduction Steps (if applicable)
Screenshots (if applicable)
Dependent Changes (if applicable)
Groups who should review (if applicable)
鉂わ笍 Thank you!