New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update message object to accept array offer param and send offer as string #2370
Conversation
Update normalizeButtonMessage
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2370 +/- ##
==========================================
+ Coverage 51.32% 51.76% +0.43%
==========================================
Files 104 149 +45
Lines 2038 12341 +10303
Branches 604 704 +100
==========================================
+ Hits 1046 6388 +5342
- Misses 889 5848 +4959
- Partials 103 105 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…as a way to accept offer
closing this PR in favor of as this is showing 22 old commit into main. NEW PR is #2392 |
Description
Ensures that the message object
offer
input remains an array but output results in message havingoffer
property as a comma-delimited stringWhy are we making these changes? Include references to any related Jira tasks or GitHub Issues
Reproduction Steps (if applicable)
Screenshots (if applicable)
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!