Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update message object to accept array offer param and send offer as string #2370

Closed
wants to merge 22 commits into from

Conversation

perco12
Copy link

@perco12 perco12 commented Apr 2, 2024

Description

Ensures that the message object offer input remains an array but output results in message having offer property as a comma-delimited string

Why are we making these changes? Include references to any related Jira tasks or GitHub Issues

Reproduction Steps (if applicable)

Screenshots (if applicable)

Dependent Changes (if applicable)

Groups who should review (if applicable)

❤️ Thank you!

@perco12 perco12 changed the base branch from main to feature/dynamic-messaging April 2, 2024 19:25
@perco12 perco12 changed the title Feature/dtcrcmerc 3014 offer list as string feat: update message object to accept array offer param and send offer as string to SCNW Apr 2, 2024
@perco12 perco12 changed the title feat: update message object to accept array offer param and send offer as string to SCNW feat: update message object to accept array offer param and send offer as string Apr 2, 2024
@perco12 perco12 marked this pull request as ready for review April 3, 2024 17:29
@perco12 perco12 requested a review from a team as a code owner April 3, 2024 17:29
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 43.90863% with 221 lines in your changes are missing coverage. Please review.

Project coverage is 51.76%. Comparing base (20c9729) to head (4789687).
Report is 56 commits behind head on main.

Current head 4789687 differs from pull request most recent head acb162b

Please upload reports for the commit acb162b to get more accurate results.

Files Patch % Lines
src/zoid/buttons/component.jsx 15.12% 101 Missing ⚠️
src/ui/buttons/props.js 52.33% 51 Missing ⚠️
src/zoid/buttons/util.js 50.94% 26 Missing ⚠️
src/ui/buttons/util.js 47.22% 19 Missing ⚠️
src/ui/buttons/buttons.jsx 45.45% 12 Missing ⚠️
src/ui/buttons/message.jsx 61.29% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2370      +/-   ##
==========================================
+ Coverage   51.32%   51.76%   +0.43%     
==========================================
  Files         104      149      +45     
  Lines        2038    12341   +10303     
  Branches      604      704     +100     
==========================================
+ Hits         1046     6388    +5342     
- Misses        889     5848    +4959     
- Partials      103      105       +2     
Flag Coverage Δ
jest 30.99% <25.00%> (-1.00%) ⬇️
karma 54.16% <90.58%> (+4.10%) ⬆️
vitest 45.52% <24.87%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Seavenly Seavenly marked this pull request as draft April 4, 2024 17:21
Base automatically changed from feature/dynamic-messaging to main April 12, 2024 18:44
src/ui/buttons/props.js Show resolved Hide resolved
src/ui/buttons/props.js Outdated Show resolved Hide resolved
test/integration/tests/button/validation.js Show resolved Hide resolved
@perco12
Copy link
Author

perco12 commented May 16, 2024

closing this PR in favor of as this is showing 22 old commit into main. NEW PR is #2392

@perco12 perco12 closed this May 16, 2024
@perco12 perco12 deleted the feature/DTCRCMERC-3014-offer-list-as-string branch May 16, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants