Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow up to #2169 (29a18ec) that introduced an issue related to the correct content not being available.
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
If some content is available, but not the correct content, the
aria-label
goes missing becauselabelText
is undefined.Additionally, the tests in style.js were silently passing because
done
was not passed toit()
and the test reported a success before the button rendered.Reproduction Steps
Visit https://developer.paypal.com/demo/checkout/#/pattern/server and update the sdk script url to include a locale that does not have corresponding content:
Then, add a style property with a label property:
Observe that there is no
aria-label
on the.paypal-button
elementScreenshots
❤️ Thank you!