fix(venmo): web config (#2189)

* fix(venmo): web config * fix(venmo): regex * chore(build): dist * fix(review): device Co-authored-by: Greg Jopa <[email protected]> --------- Co-authored-by: Steve Mask <[email protected]> Co-authored-by: Greg Jopa <[email protected]>
paypal · Jun 15, 2023 · d7fca3e · d7fca3e
1 parent d9acf38
commit d7fca3e
Show file tree

Hide file tree

Showing 6 changed files with 48 additions and 4 deletions.
diff --git a/dist/button.js b/dist/button.js
diff --git a/dist/test/button.js b/dist/test/button.js
diff --git a/dist/test/button.js.LICENSE.txt b/dist/test/button.js.LICENSE.txt
@@ -0,0 +1 @@
+/*! Isomorphic Style Loader | MIT License | https://github.com/kriasoft/isomorphic-style-loader */
diff --git a/src/zoid/venmo/component.jsx b/src/zoid/venmo/component.jsx
@@ -35,6 +35,11 @@ import type { CheckoutPropsType } from "../checkout/props";
 
 import { DEFAULT_POPUP_SIZE, HISTORY_NATIVE_POPUP_DOMAIN } from "./config";
 
+const CHANNEL = {
+ DESKTOP: "desktop-web",
+ MOBILE: "mobile-web",
+};
+
 export type VenmoCheckoutComponent = ZoidComponent<CheckoutPropsType>;
 
 export function getVenmoCheckoutComponent(): VenmoCheckoutComponent {
@@ -161,6 +166,19 @@ export function getVenmoCheckoutComponent(): VenmoCheckoutComponent {
  value: getLocale,
  },
 
+ channel: {
+ type: "string",
+ queryParam: true,
+ required: false,
+ value: () => (isDevice() ? CHANNEL.MOBILE : CHANNEL.DESKTOP),
+ },
+
+ parentDomain: {
+ type: "string",
+ queryParam: true,
+ required: true,
+ },
+
  createOrder: {
  type: "function",
  queryParam: "token",
@@ -272,6 +290,18 @@ export function getVenmoCheckoutComponent(): VenmoCheckoutComponent {
  return (handler) => event.on(EVENT.FOCUS, handler);
  },
  },
+
+ venmoWebUrl: {
+ type: "string",
+ queryParam: true,
+ required: true,
+ },
+
+ venmoWebEnabled: {
+ type: "boolean",
+ queryParam: true,
+ required: false,
+ },
  },
 
  dimensions: ({ props }) => {

diff --git a/src/zoid/venmo/config.js b/src/zoid/venmo/config.js
@@ -12,8 +12,8 @@ export const DEFAULT_POPUP_SIZE = {
 };
 
 export const HISTORY_NATIVE_POPUP_DOMAIN: EnvConfig = {
- [ENV.TEST]: "https://history.paypal.com",
- [ENV.LOCAL]: "http://localhost:8001",
+ [ENV.TEST]: "https://localhost.paypal.com:8443",
+ [ENV.LOCAL]: "https://localhost.paypal.com:8443",
  [ENV.STAGE]: "https://history.paypal.com",
  [ENV.SANDBOX]: "https://history.paypal.com",
  [ENV.PRODUCTION]: "https://history.paypal.com",

diff --git a/webpack.config.js b/webpack.config.js
@@ -33,4 +33,14 @@ export const WEBPACK_CONFIG_BUTTON_RENDER: WebpackConfig = getWebpackConfig({
  vars: globals,
 });
 
-export default [WEBPACK_CONFIG_BUTTON_RENDER];
+export const WEBPACK_CONFIG_TEST_BUTTON_RENDER: WebpackConfig = getWebpackConfig({
+ context: __dirname,
+ entry: "./src/ui/buttons",
+ filename: "./test/button.js",
+ modulename: MODULE_NAME,
+ web: false,
+ libraryTarget: "commonjs2",
+ vars: { ...getTestGlobals(globals) },
+});
+
+export default [WEBPACK_CONFIG_BUTTON_RENDER, WEBPACK_CONFIG_TEST_BUTTON_RENDER];