Merge remote-tracking branch 'origin/main' into fix-ncps-show-tagline

paypal · May 2, 2024 · 874d837 · 874d837
2 parents cb4ba28 + fd0b814
commit 874d837
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/src/hosted-buttons/index.test.js b/src/hosted-buttons/index.test.js
@@ -59,6 +59,10 @@ const getHostedButtonDetailsResponse = {
  name: "tagline",
  value: "true",
  },
+ {
+ name: "height",
+ value: "40",
+ },
  ],
  },
  },

diff --git a/src/hosted-buttons/types.js b/src/hosted-buttons/types.js
@@ -50,7 +50,7 @@ export type HostedButtonDetailsParams =
  shape: string,
  color: string,
  label: string,
- height: string,
+ height: ?number,
  tagline: boolean,
  |},
  version: ?string,

diff --git a/src/hosted-buttons/utils.js b/src/hosted-buttons/utils.js
@@ -99,7 +99,7 @@ export const getHostedButtonDetails: HostedButtonDetailsParams = async ({
  color: getButtonVariable(variables, "color"),
  label: getButtonVariable(variables, "button_text"),
  tagline: getButtonVariable(variables, "tagline") === "true",
- height: getButtonVariable(variables, "height"),
+ height: parseInt(getButtonVariable(variables, "height"), 10) || undefined,
  },
  version: body.version,
  buttonContainerId: body.button_container_id,

diff --git a/src/hosted-buttons/utils.test.js b/src/hosted-buttons/utils.test.js
@@ -86,7 +86,7 @@ describe("getHostedButtonDetails", () => {
  link_variables: [
  {
  name: "height",
- value: 50,
+ value: "50",
  },
  {
  name: "tagline",