chore: refactor email generation types to use TypedUser#16239
Closed
Sjoertjuh wants to merge 1 commit intopayloadcms:mainfrom
Closed
chore: refactor email generation types to use TypedUser#16239Sjoertjuh wants to merge 1 commit intopayloadcms:mainfrom
Sjoertjuh wants to merge 1 commit intopayloadcms:mainfrom
Conversation
Sjoertjuh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will improve the types of the auth mail methods (forgot password & verify). Currently the types are nullable for forgot password, and the user is typed as
anyfor both. This will update these types to use theTypedUser, which should help a lot.I came across this while implementing a custom email, since I had to do a lot of unneeded
nullchecks.