fix: enforce mimeTypes restriction when useTempFiles is enabled#16236
Closed
eddieran wants to merge 4 commits intopayloadcms:mainfrom
Closed
fix: enforce mimeTypes restriction when useTempFiles is enabled#16236eddieran wants to merge 4 commits intopayloadcms:mainfrom
eddieran wants to merge 4 commits intopayloadcms:mainfrom
Conversation
When `useTempFiles` is true, `file.data` is an empty buffer so `fileTypeFromBuffer` returns undefined. The fallback extension-based validation was gated behind `!useTempFiles`, which meant it was skipped entirely — allowing any file type to bypass MIME restrictions. Remove the `!useTempFiles` condition so extension-based validation always runs when buffer detection fails, regardless of temp file mode. Fixes #16233 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…lidation-tempfiles
PatrikKozak
changed the title
PatrikKozak
added a commit
that referenced
this pull request
Apr 14, 2026
This replaces #16236 which was auto-closed when the fork was deleted. # Overview Fixes MIME type validation being skipped on upload collections when `upload.useTempFiles: true` is set globally. ## Key Changes - Use `fileTypeFromFile` for temp files instead of loading the full buffer — avoids reading large files (e.g. 2GB video) into memory just for MIME detection - Removed the `!useTempFiles` gate that was causing the entire fallback validation block to be skipped - Added `tempFilePath` to the `File` type directly instead of intersecting it at the call site - Full file content is loaded lazily via `getFileBuffer()` and only when needed for SVG/PDF content validation ## Design Decisions The original code used the `useTempFiles` config flag to decide whether to run fallback validation, but checking `tempFilePath` directly is more accurate, files uploaded via the local API always have `file.data` populated even when `useTempFiles` is enabled. Simply removing the gate (as originally suggested) would've fixed the extension check but left `validateSvg` broken, since it would still run on an empty buffer and always return safe. Fixes #16233. --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Patrik Kozak <35232443+PatrikKozak@users.noreply.github.com> Co-authored-by: Paul Popus <paul@payloadcms.com>
milamer
pushed a commit
to milamer/payload
that referenced
this pull request
Apr 20, 2026
…oadcms#16255) This replaces payloadcms#16236 which was auto-closed when the fork was deleted. # Overview Fixes MIME type validation being skipped on upload collections when `upload.useTempFiles: true` is set globally. ## Key Changes - Use `fileTypeFromFile` for temp files instead of loading the full buffer — avoids reading large files (e.g. 2GB video) into memory just for MIME detection - Removed the `!useTempFiles` gate that was causing the entire fallback validation block to be skipped - Added `tempFilePath` to the `File` type directly instead of intersecting it at the call site - Full file content is loaded lazily via `getFileBuffer()` and only when needed for SVG/PDF content validation ## Design Decisions The original code used the `useTempFiles` config flag to decide whether to run fallback validation, but checking `tempFilePath` directly is more accurate, files uploaded via the local API always have `file.data` populated even when `useTempFiles` is enabled. Simply removing the gate (as originally suggested) would've fixed the extension check but left `validateSvg` broken, since it would still run on an empty buffer and always return safe. Fixes payloadcms#16233. --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Patrik Kozak <35232443+PatrikKozak@users.noreply.github.com> Co-authored-by: Paul Popus <paul@payloadcms.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes MIME type validation being skipped on upload collections when
upload.useTempFiles: trueis set globally.Key Changes
file.datais empty (as it is with temp files), read content fromfile.tempFilePathbefore running validation!useTempFilesgate that was causing the entire fallback validation block to be skippedDesign Decisions
The original code used the
useTempFilesconfig flag to decide whether to run fallback validation, but checkingtempFilePathdirectly is more accurate.Files uploaded via the local API always have
file.datapopulated even whenuseTempFilesis enabled.Simply removing the gate (as originally suggested) would've fixed the extension check but left
validateSvgbroken, since it would still run on an empty buffer and always return safe.Fixes #16233