refactor: clean up dead code and minor bugs in job queue system#16234
Merged
refactor: clean up dead code and minor bugs in job queue system#16234
Conversation
AlessioGr
commented
Apr 9, 2026
| }, | ||
| }, | ||
| updatedAt: new Date().toISOString(), | ||
| updatedAt: getCurrentDate().toISOString(), |
Member
Author
There was a problem hiding this comment.
getCurrentDate() is required for current time mocking in our test suite to work
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
AlessioGr
commented
Apr 10, 2026
| silent, | ||
| } | ||
|
|
||
| if (typeof queue === 'string') { |
Member
Author
There was a problem hiding this comment.
unnecessary, it's added regardless
AlessioGr
commented
Apr 10, 2026
| jobLog: doc.log || [], | ||
| }) | ||
| doc.input = doc.input || {} | ||
| doc.taskStatus = doc.taskStatus || {} |
Member
Author
There was a problem hiding this comment.
unnecessary, getJobTaskStatus does the same already
paulpopus
approved these changes
Apr 10, 2026
Contributor
|
🚀 This is included in version v3.83.0 |
milamer
pushed a commit
to milamer/payload
that referenced
this pull request
Apr 20, 2026
…oadcms#16234) - replaces a hardcoded `'payload-jobs'` string - uses `getCurrentDate()` consistently instead of `new Date()` - removes dead code: redundant `taskStatus` reassignment in `jobAfterRead`, commented-out debug logging in `calculateBackoffWaitUntil`, and a redundant queue reassignment in the run endpoint. - reduces `getCurrentDate()` calls in backoff calculation from four to one, - guards and simplifies logging-only array allocations behind the `silent` check in `runJobs` --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1214013522421649
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'payload-jobs'stringgetCurrentDate()consistently instead ofnew Date()taskStatusreassignment injobAfterRead, commented-out debug logging incalculateBackoffWaitUntil, and a redundant queue reassignment in the run endpoint.getCurrentDate()calls in backoff calculation from four to one,silentcheck inrunJobs