Skip to content

fix: prevent cron from permanently dying after handler errors #16219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlessioGr merged 4 commits into from
Apr 14, 2026
Merged

fix: prevent cron from permanently dying after handler errors #16219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a10d69d
fix
AlessioGr Apr 9, 2026
1acafe4
Merge remote-tracking branch 'origin/main' into fix/cron-error-handling
AlessioGr Apr 9, 2026
51b09a5
set sloppyRanges true
AlessioGr Apr 9, 2026
427ca84
Merge remote-tracking branch 'origin/main' into fix/cron-error-handling
AlessioGr Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/payload/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
"busboy": "^1.6.0",
"ci-info": "^4.1.0",
"console-table-printer": "2.12.1",
"croner": "9.1.0",
"croner": "10.0.1",
Comment thread
DanRibbens marked this conversation as resolved.
"dataloader": "2.2.3",
"deepmerge": "4.3.1",
"file-type": "21.3.4",
Expand Down
2 changes: 2 additions & 0 deletions packages/payload/src/bin/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ export const bin = async () => {
{
// Do not run consecutive crons if previous crons still ongoing
protect: true,
// TODO: Remove this compatibility option in 4.0. This only exists to ensure backwards-compatibility between Croner v9 and Croner v10 cron syntax
sloppyRanges: true,
},
)

Expand Down
5 changes: 5 additions & 0 deletions packages/payload/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,8 +739,13 @@ export class BasePayload {
})
},
{
catch: (err) => {
this.logger.error({ err, msg: 'Error in job queue cron job handler' })
},
// Do not run consecutive crons if previous crons still ongoing
protect: true,
// TODO: Remove this compatibility option in 4.0. This only exists to ensure backwards-compatibility between Croner v9 and Croner v10 cron syntax
sloppyRanges: true,
},
)

Expand Down
5 changes: 4 additions & 1 deletion packages/payload/src/queues/operations/handleSchedules/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,10 @@ export function checkQueueableTimeConstraints({
? queueScheduleStats?.tasks?.[taskConfig.slug]?.lastScheduledRun
: queueScheduleStats?.workflows?.[workflowConfig?.slug ?? '']?.lastScheduledRun

const nextRun = new Cron(scheduleConfig.cron).nextRun(lastScheduledRun ?? undefined)
const nextRun = new Cron(scheduleConfig.cron, {
// TODO: Remove this compatibility option in 4.0. This only exists to ensure backwards-compatibility between Croner v9 and Croner v10 cron syntax
sloppyRanges: true,
}).nextRun(lastScheduledRun ?? undefined)

if (!nextRun) {
return false
Expand Down
Loading
Loading