fix: parse JSON string where query param#15745
Merged
PatrikKozak merged 3 commits intopayloadcms:mainfrom Apr 9, 2026
Merged
Conversation
hugomeduarte
changed the title
hugomeduarte
changed the title
PatrikKozak
changed the title
…here-param-in-parseParams
PatrikKozak
approved these changes
Apr 9, 2026
PatrikKozak
changed the title
Contributor
|
🚀 This is included in version v3.83.0 |
milamer
pushed a commit
to milamer/payload
that referenced
this pull request
Apr 20, 2026
### What?
Support `where` sent as a JSON string in REST API requests (e.g.
`?where={"read":{"equals":false}}`). Previously the filter was silently
ignored; now it's parsed correctly.
### Why?
GET query params are always strings. `parseParams` parsed `data` this
way already but skipped `where`, so string-encoded filters had no
effect.
### How?
After the `data` block in `parseParams`: if `where` is a non-empty
string, `JSON.parse` it. If it's already an object (e.g. from bracket
notation), leave it alone.
---------
Co-authored-by: Patrik Kozak <35232443+PatrikKozak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Support
wheresent as a JSON string in REST API requests (e.g.?where={"read":{"equals":false}}). Previously the filter was silently ignored; now it's parsed correctly.Why?
GET query params are always strings.
parseParamsparseddatathis way already but skippedwhere, so string-encoded filters had no effect.How?
After the
datablock inparseParams: ifwhereis a non-empty string,JSON.parseit. If it's already an object (e.g. from bracket notation), leave it alone.