Use HeaderValue::from_static instead of a Lazy #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nothingmuch
force-pushed
the
from_static-instead-of-lazy
branch
from
8344b61 to
4c39d10
Compare
|
MSRV test failure appears to be related to #43, the GH CI script tries to update specific crates, and the update of the Since this was a small cleanup I was trying to do independently of other changes I'm preparing for PRs right now, I will return to it after that's done, converting to draft for now. |
nothingmuch
force-pushed
the
from_static-instead-of-lazy
branch
2 times, most recently
from
4c39d10 to
0d372e5
Compare
This does not remove the `once_cell` dependency since it's still used in tests, but does relegate it to a dev dependency.
nothingmuch
force-pushed
the
from_static-instead-of-lazy
branch
from
0d372e5 to
5168510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not remove the
once_celldependency since it's still used in tests, but does relegate it to a dev dependency.With the gateway probing, I think
GatewayUrimight be able to have aconst fn from_static, addressing the last remainingLazy, but I haven't tried yet so I'm not sure if that'll actually work. That said, if removing the dep is desirable then the test can just be modified.