Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Cargo-recent.lock and Cargo-minimal.lock like rust-payjoin to ease MSRV pins #43

Open
DanGould opened this issue Dec 30, 2024 · 0 comments
Open

Use Cargo-recent.lock and Cargo-minimal.lock like rust-payjoin to ease MSRV pins #43

DanGould opened this issue Dec 30, 2024 · 0 comments

Comments

@DanGould
Copy link
Collaborator

It's a whole lot easier following that pattern. I had to play around a lot to make #42 work otherwise
@nothingmuch nothingmuch mentioned this issue Mar 7, 2025
Merged
nothingmuch added a commit to nothingmuch/ohttp-relay that referenced this issue Mar 8, 2025
@nothingmuch
Don't cargo update in MSRV CI job
45a17c1 
Since not all dependencies have precise semvers constraints, a blanket
cargo update can break MSRV.

This means that the repository can bitrot, with CI jobs failing in ways
not related to changes to the codebase.

This is a workaround, see also payjoin#43 for description of the proper way to
fix this.
@nothingmuch nothingmuch mentioned this issue Mar 8, 2025
Draft
nothingmuch added a commit to nothingmuch/ohttp-relay that referenced this issue Mar 8, 2025
@nothingmuch
Don't cargo update in MSRV CI job
305802a 
Since not all dependencies have precise semvers constraints, a blanket
cargo update can break MSRV.

This means that the repository can bitrot, with CI jobs failing in ways
not related to changes to the codebase.

This is a workaround, see also payjoin#43 for description of the proper way to
fix this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DanGould