Skip to content

refactor: connack timeout error 이벤트 emit 코드를 제거 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2024
Merged

refactor: connack timeout error 이벤트 emit 코드를 제거 #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/lib/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,6 @@ export default class MqttClient extends TypedEventEmitter<MqttClientEventCallbac
this.log(
'!!connectTimeout hit!! Calling _cleanUp with force `true`',
)
this.emit('error', new Error('connack timeout'))
this._cleanUp(true)
}, this.options.connectTimeout)

Expand Down
12 changes: 0 additions & 12 deletions test/abstract_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3004,18 +3004,6 @@ export default function abstractTest(server, config, ports) {
}, 50)
})

it('should emit connack timeout error', function _test(t, done) {
const client = connect({
connectTimeout: 0,
reconnectPeriod: 5000,
})

client.on('error', (err) => {
assert.equal(err.message, 'connack timeout')
client.end(true, done)
})
})

it(
'should resend in-flight QoS 1 publish messages from the client',
{
Expand Down