-
Notifications
You must be signed in to change notification settings - Fork 19
fix: Add comprehensive webhook cleanup for Transfer events #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Made deleteTransferWebhook dynamic to handle both txHash and paymentOrderID - Added webhook deletion to UpdateReceiveAddressStatus for Transfer events - Prevents orphaned webhooks when Etherscan/Blockscout processes Transfer events - Ensures immediate cleanup when transfer is received, not delayed until OrderCreated - Function auto-detects UUID format for paymentOrderID vs txHash lookup
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💯 |
… cleanup for old webhooks
… webhook deletion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* fix: Add comprehensive webhook cleanup for Transfer events - Made deleteTransferWebhook dynamic to handle both txHash and paymentOrderID - Added webhook deletion to UpdateReceiveAddressStatus for Transfer events - Prevents orphaned webhooks when Etherscan/Blockscout processes Transfer events - Ensures immediate cleanup when transfer is received, not delayed until OrderCreated - Function auto-detects UUID format for paymentOrderID vs txHash lookup * fix: update documentation for webhook handling and order status updates * fix: update transfer webhook deletion to use transaction hash and add cleanup for old webhooks * fix: implement cleanup for old webhooks and enhance webhook handling * fix: remove outdated webhook cleanup function and streamline transfer webhook deletion
Description
References
Testing
Checklist
main
By submitting a PR, I agree to Paycrest's Contributor Code of Conduct and Contribution Guide.