Add Slack Notifications for New User Registrations #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundayonah
requested review from
chibie,
5ran6 and
onahprosper
as code owners
sundayonah
changed the title
onahprosper
reviewed
Feb 3, 2025
…s also update env's
5ran6
reviewed
Feb 4, 2025
services/slack.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func contains(slice []string, str string) bool { |
There was a problem hiding this comment.
@sundayonah this should be moved to utils.go
5ran6
requested changes
Feb 4, 2025
…ize existing Contains function, and add new Slack webhook URL
onahprosper
reviewed
Feb 17, 2025
chibie
requested changes
Mar 7, 2025
services/slack.go
Outdated
|
|
||
| // Log error if notification failed, but don't interrupt registration | ||
| if resp.StatusCode != http.StatusOK { | ||
| logger.Errorf("Slack notification failed with status: %d", resp.StatusCode) |
There was a problem hiding this comment.
this error should be returned since it's handled in auth.go
…m/paycrest/aggregator into add-slack-notifications-on-signup
…m/paycrest/aggregator into add-slack-notifications-on-signup
chibie
requested changes
Mar 18, 2025
controllers/accounts/auth.go
Outdated
Comment on lines
173
to
177
| // Assign providerCurrency from the first valid fiat currency | ||
| if len(fiatCurrencies) > 0 { | ||
| providerCurrency = fiatCurrencies[0].Code | ||
| } | ||
|
|
There was a problem hiding this comment.
this code isn't needed... all currencies should be sent in the notification
controllers/accounts/auth.go
Outdated
Comment on lines
252
to
253
| if err := ctrl.slackService.SendUserSignupNotification(user, scopes, providerCurrency); err != nil { | ||
| logger.Errorf("failed to send Slack notification: %v", err) |
There was a problem hiding this comment.
include all the provided currencies in the slack notification separated by comma
e.g
NGN, KES
…es in Slack notification as comma-separated list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements Slack notifications for new user signups, notifying administrators when a user registers. This feature includes user details such as user ID, email, first name, last name, role (provider or sender), and provider-specific details (e.g., currency for providers). The notifications will be sent only in the production environment, and errors in sending the notifications will be logged without interrupting the registration process.
References
n/a
Testing
User signup and Slack notification service integration
Role-specific notifications (provider/sender)
Slack webhook error handling and logging
Environment-specific notification dispatch (production only)
Checklist
closes #410