Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced Precompiled Headers support #145

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Advanced Precompiled Headers support #145

wants to merge 3 commits into from

Conversation

Victor-Y-Fadeev
Copy link

Added -pch flag for advanced Precompiled Headers usage:

Added -dio flag to disable INTERPROCEDURAL_OPTIMIZATION because it's not equal to /GL and can cause debug problems.

pavelliavonau
pavelliavonau reviewed Apr 3, 2023
View reviewed changes
cmake_converter/utils.cmake
function(use_precompiled_header SRC_LIST_VAR HEADER_FILE SOURCE_FILE)
if(NOT MSVC)
target_precompile_headers(${PROJECT_NAME} PRIVATE
"$<$<COMPILE_LANGUAGE:CXX>:${CMAKE_CURRENT_SOURCE_DIR}/${HEADER_FILE}>")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you build your project on linux?

cmake_converter/main.py
default=False,
action='store_true'
)
parser.add_argument(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is not related to this PR subject. ipo changes should be extracted to another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelliavonau pavelliavonau pavelliavonau left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Victor-Y-Fadeev @pavelliavonau