Skip to content

Rust 2024 #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Rust 2024 #708

wants to merge 2 commits into from

Conversation

Billy-Sheppard
Copy link

Few things of note.

  • I've fixed all the lints clippy requested, but I can revert if not desired
  • I've updated all crates as new as possible (excl bincode)
  • Passes all tests locally (except for readme_deps)
  • Compiles locally (except for one error with diesel?)
  • Had to convert the #![forbid(unsafe_code)] to a #![deny(unsafe_code)]
    • this is for:
#[allow(unsafe_code)]
#[cfg(feature = "rkyv")]
unsafe impl Portable for Decimal {}

Let me know how else I can confirm this is ready for a merge.

@Tony-Samuels
Copy link
Collaborator

This library maintains support for rust compiler versions that are 4 minor versions away from the current stable rust compiler version.

I haven't actually tested this to be certain, but I expect we'll need to hold off on a 2024 edition bump for another few minor releases before we can release this and uphold our guarantees.

@Billy-Sheppard
Copy link
Author

Excellent, no worries

@Tony-Samuels
Copy link
Collaborator

This has been done on the master branch now, which will become the basis of the 2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants