Skip to content

feat(Form): enabled opt-in animations for expandable fieldgroup #11843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thatblindgeye
Copy link
Contributor

What: Closes #11840

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented May 22, 2025

Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing appears slightly off compared with the main site? I'm looking at the spacing above those dividers.

Screenshot 2025-05-28 at 9 49 23 AM

@thatblindgeye thatblindgeye requested a review from nicolethoen June 5, 2025 17:13
@mcoker mcoker requested a review from srambach June 6, 2025 19:13
Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to my comment on TreeView - I think there are very valid reasons why a use case might incline a dev to want to dynamically create and render children of field groups. It may that they didn't load all the information from the backend on page load, and for performance reasons will only retrieve values for the collapsed field groups when they are expanded open... Something to keep in mind

@thatblindgeye
Copy link
Contributor Author

Spacing appears slightly off compared with the main site? I'm looking at the spacing above those dividers.

@rebeccaalpert looks like the bug is also in Core when I copy+paste the React HTML into a Core example and revert the changes locally (other than bumping the Core versions). @srambach just FYI ^ in Rebecca's screenshot above there's a divider between "Nested field group 2 (non-expandable)" and the text input above it, but there's no spacing between the input and the divider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form - support for field group animation
5 participants