chore(card): add ability to hide radio button in example #11832
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,63 +1,81 @@ | ||
| import { useState } from 'react'; | ||
| import { Card, CardHeader, CardTitle, CardBody, Gallery, Checkbox } from '@patternfly/react-core'; | ||
|
|
||
| export const SingleSelectableCard: React.FunctionComponent = () => { | ||
| const [isChecked, setIsChecked] = useState(''); | ||
| const id1 = 'single-selectable-card-input-1'; | ||
| const id2 = 'single-selectable-card-input-2'; | ||
| const id3 = 'single-selectable-card-input-3'; | ||
| const [displayRadioButton, setDisplayRadioButton] = useState<boolean>(false); | ||
|
|
||
| const onChange = (event: React.FormEvent<HTMLInputElement>) => { | ||
| setIsChecked(event.currentTarget.id); | ||
| }; | ||
|
|
||
| const toggleHide = (checked: boolean) => { | ||
| setDisplayRadioButton(checked); | ||
| }; | ||
|
|
||
| return ( | ||
| <> | ||
| <Checkbox | ||
| label="Hide radio button" | ||
| isChecked={displayRadioButton} | ||
| onChange={(_event, checked) => toggleHide(checked)} | ||
| id="toggle-hide-radio-button" | ||
| name="toggle-hide" | ||
| /> | ||
| <div style={{ marginTop: '15px' }}></div> | ||
|
There was a problem hiding this comment. I think this will depend on Erin's response to my general review comment above, but if we do want to update the "Selectable" example as well to include this "hide input" logic, I think we could remove these empty divs and instead either apply a margin to the checkbox or gallery, or try wrapping everything in a Flex layout and utilizing gap. There was a problem hiding this comment. RE "do you think we should also update the "Selectable" example to match with a checkbox that can hide the Card inputs?" yes, I do! Would be good to match, I actually thought it was already there 😅 |
||
| <Gallery hasGutter> | ||
| <Card id="single-selectable-card-example-1" isSelectable isSelected={isChecked === id1}> | ||
| <CardHeader | ||
| selectableActions={{ | ||
| selectableActionId: id1, | ||
| selectableActionAriaLabelledby: 'single-selectable-card-example-1', | ||
| name: 'single-selectable-card-example', | ||
| variant: 'single', | ||
| onChange, | ||
| hasNoOffset: true, | ||
| isHidden: displayRadioButton | ||
| }} | ||
| > | ||
| <CardTitle>First card</CardTitle> | ||
| </CardHeader> | ||
| <CardBody>This card is single selectable.</CardBody> | ||
| </Card> | ||
| <Card id="single-selectable-card-example-2" isSelectable isSelected={isChecked === id2}> | ||
| <CardHeader | ||
| selectableActions={{ | ||
| selectableActionId: id2, | ||
| selectableActionAriaLabelledby: 'single-selectable-card-example-2', | ||
| name: 'single-selectable-card-example', | ||
| variant: 'single', | ||
| onChange, | ||
| hasNoOffset: true, | ||
| isHidden: displayRadioButton | ||
| }} | ||
| > | ||
| <CardTitle>Second card</CardTitle> | ||
| </CardHeader> | ||
| <CardBody>This card is single selectable.</CardBody> | ||
| </Card> | ||
| <Card id="single-selectable-card-example-3" isSelectable isDisabled isSelected={isChecked === id3}> | ||
| <CardHeader | ||
| selectableActions={{ | ||
| selectableActionId: id3, | ||
| selectableActionAriaLabelledby: 'single-selectable-card-example-3', | ||
| name: 'single-selectable-card-example', | ||
| variant: 'single', | ||
| onChange, | ||
| hasNoOffset: true, | ||
| isHidden: displayRadioButton | ||
| }} | ||
| > | ||
| <CardTitle>Third card</CardTitle> | ||
| </CardHeader> | ||
| <CardBody>This card is single selectable but disabled.</CardBody> | ||
| </Card> | ||
| </Gallery> | ||
| </> | ||
| ); | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit verbose, but just to ensure it's unique