Skip to content

chore(docs): update filters for tokens #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

evwilkin
Copy link
Member

@evwilkin evwilkin commented Sep 4, 2024

This PR:

  • Updates the filters to match the token layers (Semantic, Base, Palette, Charts) and defaults to Semantic view.
  • Fixes bug where multiple layers of tokens show in one view. Visible tokens now only reflect the selected layer.
  • Adds expandable rows for all tokens that evaluate to a color (currently some tokens have color values that show a preview but have no way to view the value).
  • Adds results count when a search term is entered.

@evwilkin
Copy link
Member Author

evwilkin commented Sep 9, 2024

@srambach
Copy link
Member

srambach commented Oct 9, 2024

I find this a little confusing since palette and chart are both tabs and in the dropdown.
I think I also got into an incorrect state - ?
image

@evwilkin
Copy link
Member Author

Thanks @srambach I see that too. Will dive back in to address this feedback 👍

@evwilkin evwilkin changed the title chore(docs): added tabs to select token layer to display chore(docs): update filters for tokens Feb 20, 2025
@srambach srambach requested review from a team, lboehling and bekah-stephens and removed request for a team May 6, 2025 19:23
Copy link

@bekah-stephens bekah-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! the only thing I noticed is that we don't have an empty state when the search/filter results are 0. not a huge deal, but the blank space with the floating table headers is a bit odd.

image

@evwilkin
Copy link
Member Author

evwilkin commented May 7, 2025

@bekah-stephens updated w/empty state 🥇 and fixed styling of the "0" count shown in your screenshot above

Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌮

@srambach srambach requested review from kmcfaul and bekah-stephens May 7, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants