Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only prohibit self-approval for sensitive files #49

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Sep 17, 2024

Resolves #48

@corneliusroemer corneliusroemer changed the title ci: only prohibit self-approval for sensitive files feat: only prohibit self-approval for sensitive files Sep 17, 2024
Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait? Why? Could you explain the background a bit, please?

Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Withdrawing my change request after discussion with @corneliusroemer

@corneliusroemer corneliusroemer merged commit 2f12abc into main Sep 17, 2024
4 checks passed
@corneliusroemer corneliusroemer deleted the self-approval-block-prod-only branch September 17, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically triggered bot PR without triggerer fails self-approval checks
3 participants